Bounding rects #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemnovichkov
requested review from
disabled,
Antowkos,
ReshetovE,
ntunin,
evgenmikhaylov and
stason314
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 98.74% 98.85% +0.11%
==========================================
Files 16 17 +1
Lines 636 697 +61
==========================================
+ Hits 628 689 +61
Misses 8 8
Continue to review full report at Codecov.
|
stason314
approved these changes
Jul 1, 2019
rosberry
approved these changes
Jul 1, 2019
Co-Authored-By: Rosberry <serge.gorbachev@rosberry.com>
Antowkos
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
Textfunction for bounding rect calculation. There are default parameters, so for common case you should pass only constrained size. Please check related tests for more examples.Related to #3