Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敘 Enhancements #8

Merged
merged 17 commits into from
Jul 19, 2019
Merged

馃敘 Enhancements #8

merged 17 commits into from
Jul 19, 2019

Conversation

artemnovichkov
Copy link
Contributor

There are some useful changes in this request. I decided to combine it into one PR to reduce code review hell :)
Here is a checklist for the changes:

  • Array extension for texts joining. Supports custom separator
  • Custom + operator for texts and strings
  • Add missing attributes: ligature, shadow, strokeColor
  • Add string concatenation for text

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.9%.
The diff coverage is 99.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #8     +/-   ##
=========================================
+ Coverage   98.79%   99.69%   +0.9%     
=========================================
  Files          16       22      +6     
  Lines         662      979    +317     
=========================================
+ Hits          654      976    +322     
+ Misses          8        3      -5
Impacted Files Coverage 螖
Texstyle/Texstyle/Text.swift 100% <酶> (酶) 猬嗭笍
Texstyle/Texstyle/StringInterpolation+Text.swift 100% <100%> (酶)
Texstyle/Texstyle/TextStyle.swift 100% <100%> (酶) 猬嗭笍
Texstyle/TexstyleTests/ShadowStyleTests.swift 100% <100%> (酶)
Texstyle/TexstyleTests/ShadowStyle+Random.swift 100% <100%> (酶)
Texstyle/TexstyleTests/TextTests.swift 99.78% <100%> (+2.77%) 猬嗭笍
Texstyle/TexstyleTests/TextStyle+Random.swift 100% <100%> (酶) 猬嗭笍
Texstyle/TexstyleTests/StringTests.swift 100% <100%> (酶) 猬嗭笍
Texstyle/Texstyle/ShadowStyle.swift 100% <100%> (酶)
Texstyle/TexstyleTests/TextStyleTests.swift 100% <100%> (酶) 猬嗭笍
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 816194d...70af0f8. Read the comment docs.

Texstyle/Texstyle/Array+Text.swift Outdated Show resolved Hide resolved
Texstyle/Texstyle/Array+Text.swift Show resolved Hide resolved
Texstyle/Texstyle/Text+Operators.swift Show resolved Hide resolved
Texstyle/Texstyle/Text.swift Show resolved Hide resolved
Texstyle/Texstyle/TextStyle.swift Outdated Show resolved Hide resolved
Texstyle/Texstyle/Array+Text.swift Show resolved Hide resolved
Texstyle/Texstyle/Array+Text.swift Show resolved Hide resolved
@artemnovichkov artemnovichkov merged commit 70af0f8 into master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants