Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lsp_signature support #17

Closed
danymat opened this issue Aug 24, 2021 · 4 comments
Closed

Lsp_signature support #17

danymat opened this issue Aug 24, 2021 · 4 comments

Comments

@danymat
Copy link
Contributor

danymat commented Aug 24, 2021

I don't know if it's possible to do, but lsp_signature is quite weird with rose-pine. I would love true rose pine support for it.

Btw, can you for your wonderful work, I use rose pine dawn daily and fully ! Such a beautiful color scheme .

@mvllow
Copy link
Member

mvllow commented Aug 24, 2021

Appreciate the kind words 🥰

Here's what I think you are looking at so please correct me if I'm wrong:

Screen Shot 2021-08-24 at 12 38 45

I'd love an example of how you want it to look, eg. screenshot of another theme you may like. I'd be happy to adapt it visually to fit Rosé Pine. Thanks!

@danymat
Copy link
Contributor Author

danymat commented Aug 24, 2021

It does look like this with Dawn variant

Capture d’écran 2021-08-24 à 21 46 23

You can see that the border is very subtle, I think it could be nicer if it is with a primary dark color, don't you think?

@mvllow mvllow closed this as completed in cd7bafb Aug 24, 2021
@mvllow
Copy link
Member

mvllow commented Aug 24, 2021

Increased the contrast a bit of FloatBorder, hope that's what you had in mind 😌

(I was also considering making the border the same as the text color, if you have any thoughts on that please let me know)

@danymat
Copy link
Contributor Author

danymat commented Aug 24, 2021

Yes it is a lot cooler, thank you !!
(Be sure that I do love this colorscheme)

Capture d’écran 2021-08-24 à 23 27 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants