Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up group api #34

Closed
mvllow opened this issue Nov 19, 2021 · 4 comments · Fixed by #64
Closed

Clean up group api #34

mvllow opened this issue Nov 19, 2021 · 4 comments · Fixed by #64

Comments

@mvllow
Copy link
Member

mvllow commented Nov 19, 2021

It would be nice to partially override all group values. Currently, the exposed groups focus on fg only, eg. comment = '#282828'. This becomes less intuitive when considering a float group where we may want float = { fg = '#fff', bg = '#000' }.

Plan

  • Custom groups accept a table with some or all of the following: { fg = '', bg = '', style = '' }
  • Default config should be used as a fallback for any omitted values

Before

vim.g.rose_pine_colors = {
  comment = '#282828'
}

After

vim.g.rose_pine_colors = {
  comment = { fg = '#282828' }
}
@plmwd
Copy link

plmwd commented Dec 29, 2021

Any update on this? I can take it on if you got busy. 😄

@mvllow
Copy link
Member Author

mvllow commented Dec 29, 2021

That would be much appreciated if you're comfortable working on it 😌

@plmwd
Copy link

plmwd commented Jan 10, 2022

I'll try to make time for it soon. I'm sure you know how it is when things you want to do keep on slipping due to other things.

@mvllow
Copy link
Member Author

mvllow commented Feb 7, 2022

Going to close this as the canary branch is currently being refactored to use lua config. May create a new issue once that's merged.

@mvllow mvllow closed this as completed Feb 7, 2022
@mvllow mvllow linked a pull request Feb 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants