Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong PRF labels for chaining key extract/init #67

Closed
stv0g opened this issue May 20, 2023 · 2 comments
Closed

Wrong PRF labels for chaining key extract/init #67

stv0g opened this issue May 20, 2023 · 2 comments
Assignees
@Mullana
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@stv0g
Copy link
Contributor

stv0g commented May 20, 2023

  • Page 8 mentions: key chaining extract & key chaining init
  • Pages 9 & 18 mention: chaining key extract & chaining key init

Which constant should be used?
@koraa
Copy link
Member

koraa commented May 22, 2023 •
edited

"chaining key extract" & "chaining key init"

-- labeled_prf.rs

@Mullana could you please update Fig 3 to fix this?

@koraa koraa closed this as completed May 22, 2023
@koraa koraa reopened this May 22, 2023
@koraa koraa added bug Something isn't working documentation Improvements or additions to documentation labels May 22, 2023
@Mullana
Copy link
Contributor

Mullana commented May 22, 2023

fixed!

@stv0g stv0g mentioned this issue May 24, 2023
Open
15 tasks
@stv0g stv0g changed the title Inconsistent string constants in whitepaper Wrong PRF labels for chaining key extract/init May 24, 2023
@koraa koraa closed this as completed Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mullana Mullana

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stv0g @koraa @Mullana