Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reuse sh runner instance #62

Closed
TorchedSammy opened this issue Jun 12, 2021 · 2 comments
Closed

fix: reuse sh runner instance #62

TorchedSammy opened this issue Jun 12, 2021 · 2 comments
Labels
enhancement New feature or request up for grabs (easy) issues open for anyone; not necessarily help wanted
Milestone
v0.6

Comments

@TorchedSammy
Copy link
Member

on every command, we create a new sh runner to execute our sh. this is a little bit inefficient. if a global runner was used,
it would hold old declared env variables, and shell scripts would be able to be sourced
@TorchedSammy TorchedSammy added enhancement New feature or request up for grabs (easy) issues open for anyone; not necessarily help wanted labels Jun 12, 2021
@TorchedSammy TorchedSammy added this to the v0.6 milestone Jun 12, 2021
@TorchedSammy
Copy link
Member Author

done with 822b287

@TorchedSammy
Copy link
Member Author

this was reverted a long while ago due to breakage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request up for grabs (easy) issues open for anyone; not necessarily help wanted
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
1 participant
@TorchedSammy