Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any function to do with Find And Replace is not currently working. Do not use them, you will not get the expected result. #1

Closed
rosidae opened this issue Sep 13, 2021 · 5 comments
Closed

Any function to do with Find And Replace is not currently working. Do not use them, you will not get the expected result. #1

rosidae opened this issue Sep 13, 2021 · 5 comments
Assignees
@rosidae
Labels
invalid This doesn't seem right

Comments

@rosidae
Copy link
Collaborator

rosidae commented Sep 13, 2021 •
edited

I am currently investigating this bug and I expect it to be fixed by tomorrow.
@rosidae rosidae self-assigned this Sep 13, 2021
@rosidae
Copy link
Collaborator Author

rosidae commented Sep 13, 2021 •
edited

Update: Found an issue with Read_File(). Fixed in 76f0917

@rosidae
Copy link
Collaborator Author

rosidae commented Sep 13, 2021 •
edited

Update: Fixed completely with commit in e9a600f

@rosidae rosidae added the Fixed label Sep 13, 2021
@rosidae rosidae closed this as completed Sep 13, 2021
@rosidae rosidae reopened this Sep 13, 2021
@rosidae
Copy link
Collaborator Author

rosidae commented Sep 13, 2021

Objection: Any special characters in the replace string will potentially produce unwanted results. This is because we are using Regex (i hate regex) and converting the replace string to regex, which produces unwanted results in this case.

@rosidae rosidae added invalid This doesn't seem right and removed Fixed labels Sep 13, 2021
@rosidae rosidae pinned this issue Sep 13, 2021
@rosidae
Copy link
Collaborator Author

rosidae commented Sep 14, 2021

Update: My top goal today is to get this fixed so that we either

  1. Do not use regex
  2. Escape special regex characters

@rosidae
Copy link
Collaborator Author

rosidae commented Sep 20, 2021 •
edited

Removed find and replace, sorry. c70711b

@rosidae rosidae closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosidae rosidae

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rosidae