Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on NoiseInjection #124

Open
XavierXiao opened this issue Jul 4, 2021 · 1 comment
Open

Question on NoiseInjection #124

XavierXiao opened this issue Jul 4, 2021 · 1 comment

Comments

@XavierXiao
Copy link

XavierXiao commented Jul 4, 2021

Hi, thanks for the nice implementation. In your implementation for NoiseInjection, you have
self.weight = nn.Parameter(torch.zeros(1, channel, 1, 1))
and you apply the noise by
image + self.weight * noise

But in Facebook's implmentation (https://github.com/facebookresearch/pytorch_GAN_zoo/blob/b75dee40918caabb4fe7ec561522717bf096a8cb/models/networks/styleGAN.py#L35), it looks like they scale the noise once and add the same noise to each channel?

@XavierXiao XavierXiao reopened this Jul 4, 2021
@rosinality
Copy link
Owner

https://github.com/NVlabs/stylegan/blob/master/training/networks_stylegan.py#L270 Official implementation uses per-channel noise weights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants