feat(tests): improove code coverage

rosostolato · Aug 17, 2018 · 46eb968 · 46eb968
1 parent 993011c
commit 46eb968
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/demo/restApi.service.ts b/demo/restApi.service.ts
@@ -19,7 +19,7 @@ export class RestApi extends RestBase {
   }
 
   protected mapModel(method: HttpMethod, route: string, data: any) {
-    if (route === 'posts') {
+    if (method !== HttpMethod.DELETE && route === 'posts') {
       return new Post(data);
     }
 

diff --git a/src/restModel.ts b/src/restModel.ts
@@ -35,7 +35,8 @@ export class RestModelBase<T> extends RestRoute {
   }
 
   delete(params?: HttpParams): Observable<any> {
-    return this.createModelHttpRequest('DELETE', params);
+    return this.createModelHttpRequest('DELETE', params)
+      .pipe(map(response => this.makeRest<T>(HttpMethod.PUT, response)));
   }
 
   getPlain(): T {
@@ -56,7 +57,7 @@ export class RestModelBase<T> extends RestRoute {
     ];
 
     for (const key of methods) {
-      if (key) { delete proto[key]; }
+      delete proto[key];
     }
 
     Object.setPrototypeOf(plain, proto);

diff --git a/test/restModel.spec.ts b/test/restModel.spec.ts
@@ -2,7 +2,7 @@ import { TestBed, async } from '@angular/core/testing';
 import { HttpClientModule } from '@angular/common/http';
 import { RestApi } from '../demo/restApi.service';
 import { expect } from 'chai';
-import { RestModel, RestRoute } from '../src';
+import { RestModel, RestRoute, RestModelBase } from '../src';
 import { Post } from '../demo/models/Post';
 
 describe('RestModel', () => {
@@ -30,7 +30,7 @@ describe('RestModel', () => {
 
   it('should delete', async(() => {
     post.delete().subscribe(res => {
-      expect(res).to.be.eql({});
+      expect(res).to.be.an.instanceof(RestModelBase);
     });
   }));