Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bytes for uint8[] field #40

Merged
merged 2 commits into from
May 9, 2021
Merged

Use bytes for uint8[] field #40

merged 2 commits into from
May 9, 2021

Conversation

bonprosoft
Copy link
Member

@bonprosoft bonprosoft commented May 8, 2021 •
edited
Loading

Merge #39 first

ROS uses bytes for the uint8[], so I added the special-case handling for that.

@bonprosoft bonprosoft requested a review from otamachan May 8, 2021 17:37
@bonprosoft bonprosoft changed the base branch from master to fix_serialization_type May 8, 2021 17:43
@bonprosoft bonprosoft added the bug Something isn't working label May 9, 2021
Base automatically changed from fix_serialization_type to master May 9, 2021 04:07
@bonprosoft bonprosoft merged commit 311610e into master May 9, 2021
@bonprosoft bonprosoft deleted the uint8_array branch May 9, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otamachan otamachan Awaiting requested review from otamachan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bonprosoft