-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tags for corresponding releases #42
Comments
Looking at https://pypi.org/project/ipycache/#history, we have the following releases and I've found the commit hashes that were most likely responsible for them, primarily by matching
@rossant — would you like to double-check these commit hashes before I create tags for these historical releases? |
Looks good! 🙏 |
Since one cannot create tags for historical commits via the GitHub UI, my plan is to do this via CLI and push it as follows: Create tags
Test on my own repoPush the tags to my fork of this repo (for me, this is
Push upstreamAssuming the push to my fork goes well and looks good, push to this repo (for me, this repo is
|
Create tags locally:
Local verification:
Looks good! Here's my git remote config (for context on the following set of commands):
Pushing to my own repo:
Looks good! https://github.com/mbrukman/ipycache/tags has all the expected tags with expected commit hashes, and in particular, the dates of the tags match the dates of the commits, so looks good from a historical perspective as well. Finally, pushing to this repo:
Looks good! https://github.com/rossant/ipycache/tags has the expected content as well. |
Great thank you! 😄 Feel free to close when you are ready |
We're almost done, but not quite yet! I figured I might as well finish this rather than open another bug to re-create all releases as well. The tags are all there, and since we now have good tags, we can create releases from those tags, so that folks can easily download snapshots from this repo (though they can also easily do this from PyPI as well) — the main value I see is that GitHub makes it really easy to add a link to show all the changes that have gone into the release, so you can see the delta between release N and N+1. We now have following releases:
This means that the GitHub release history page (https://github.com/rossant/ipycache/releases) now matches the PyPI release history (https://pypi.org/project/ipycache/#history). FWIW, I marked all releases as "pre-release" since the version numbers are 0.y.z, and since Line 26 in 8fd4562
At some point, maybe we should create a "stable" release, but that's a conversation for another day. Now we're done. |
It would be really helpful if we could have tags for corresponding releases here. In particular, this would help us checkout that release and test it before we package and ship it in conda-forge.
cc @jochym
The text was updated successfully, but these errors were encountered: