Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with dplyr API #5

Merged
merged 11 commits into from Jul 21, 2023

Conversation

rossellhayes
Copy link
Owner

  • Accept named arguments with or without preceding dots, e.g. default or .default.
  • Take default into account when determining the class of output.
  • Improve error messages.

@rossellhayes rossellhayes added the enhancement New feature or request label Jul 21, 2023
@rossellhayes rossellhayes self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.66 🎉

Comparison is base (3c4f4f3) 99.33% compared to head (c914a16) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #5      +/-   ##
===========================================
+ Coverage   99.33%   100.00%   +0.66%     
===========================================
  Files          11        11              
  Lines         301       346      +45     
===========================================
+ Hits          299       346      +47     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
R/fn_case.R 100.00% <100.00%> (ø)
R/in_case.R 100.00% <100.00%> (ø)
R/in_case_fct.R 100.00% <100.00%> (ø)
R/in_case_list.R 100.00% <100.00%> (ø)
R/replace.R 100.00% <100.00%> (ø)
R/staticimports.R 100.00% <100.00%> (ø)
R/switch_case.R 100.00% <100.00%> (ø)
R/utils.R 100.00% <100.00%> (ø)
R/validate_case_length.R 100.00% <100.00%> (+6.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rossellhayes rossellhayes force-pushed the refactor/improve-compatibility-with-dplyr branch from a90a993 to c914a16 Compare July 21, 2023 19:12
@rossellhayes rossellhayes merged commit 6fa5b41 into main Jul 21, 2023
14 checks passed
@rossellhayes rossellhayes deleted the refactor/improve-compatibility-with-dplyr branch July 21, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant