Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interrupting the edit command leaves a temporary file in the config directory #111

Closed
rossmacarthur opened this issue Sep 30, 2020 · 2 comments
Closed

Interrupting the edit command leaves a temporary file in the config directory #111

rossmacarthur opened this issue Sep 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@rossmacarthur
Copy link
Owner

rossmacarthur commented Sep 30, 2020 •
edited
Loading

To reproduce

EDITOR="code --wait" sheldon edit

Press Ctrl-C while VS Code is open.

$ ls ~/.sheldon
plugins-tmp-5232.toml
plugins.lock
plugins.toml
repos
@rossmacarthur rossmacarthur added the bug Something isn't working label Sep 30, 2020
@rossmacarthur
Copy link
Owner Author

rossmacarthur commented Oct 2, 2020 •
edited
Loading

I think we should probably just use the same temporary file and if the user tries to edit again we tell the user and ask if they want to reopen or delete it.

@rossmacarthur rossmacarthur changed the title Interrupting the edit command leaves a temporary file in the root directory Interrupting the edit command leaves a temporary file in the config directory Oct 8, 2020
@rossmacarthur
Copy link
Owner Author

Fixed in 24437c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rossmacarthur