Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #26

Closed
rossmoody opened this issue Jul 17, 2019 · 1 comment
Closed

Improve error handling #26

rossmoody opened this issue Jul 17, 2019 · 1 comment

Comments

@rossmoody
Copy link
Owner

There is a generic try catch but it would be a lot more helpful to provide accessible reasons for why the extension isn't working.

@NAjustin
Copy link
Collaborator

NAjustin commented Nov 8, 2019

Running into this currently. Our team has many Google Data Studio reports that we're using this tool on, but on some the plugin fails to open and shows a generic error along these lines:

😢 There's an error: "TypeError: Cannot read property 'tagName' of null"

Unfortunately this makes it quite difficult to know what element it had an issue with. I'm thinking a short-term solution would be to output additional details to the console, such as the element that caused the error, any details from the SVG parsing, etc.

In some cases, file-level errors may be able to be gracefully handled and show an error card (so the user is aware that there was a problem), while still allowing other SVGs to be downloaded.

I'll try to make a reproducible case and see where I can take this from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants