Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error chain trace in Sentry #83

Closed
Dragomir-Ivanov opened this issue Apr 20, 2020 · 3 comments · Fixed by #85
Closed

Missing error chain trace in Sentry #83

Dragomir-Ivanov opened this issue Apr 20, 2020 · 3 comments · Fixed by #85
Assignees
Labels
bug Something isn't working
Projects

Comments

@Dragomir-Ivanov
Copy link

Dragomir-Ivanov commented Apr 20, 2020

When logging to Sentry, error chain trace is missing. Text representation of wrapped errors is there, but no File:Location trace.
Using provided example:

go run examples/sentry/example.go -dsn=<Valid Sentry DSN>

Results in Sentry FULL mode:

EXCEPTION(most recent call first)

*eris.rootError
test
*eris.wrapError
wrap 1: test
*eris.wrapError
wrap 2: wrap 1: test
*eris.wrapError
wrap 3: wrap 2: wrap 1: test

example.go in main at line 54
	})
	if initErr != nil {
		log.Fatalf("failed to initialize Sentry: %v", initErr)
	}
	sentry.CaptureException(err)
	sentry.Flush(time.Second * 5)
}

Results in Sentry RAW mode:

EXCEPTION(most recent call first)

*eris.wrapError: wrap 3: wrap 2: wrap 1: test
  File "example.go", line 54, in main
    sentry.CaptureException(err)
@sum2000
Copy link
Member

sum2000 commented Apr 20, 2020

Thanks @Dragomir-Ivanov , looking into it.

@sum2000 sum2000 added the bug Something isn't working label Apr 20, 2020
@sum2000 sum2000 self-assigned this Apr 20, 2020
@sum2000 sum2000 added this to To do in v0.4.0 via automation Apr 20, 2020
v0.4.0 automation moved this from To do to Done May 3, 2020
@sum2000
Copy link
Member

sum2000 commented May 3, 2020

Hey @Dragomir-Ivanov, this issue has been fixed. Let us know if you are still unable to see the trace on Sentry. Thanks for the input.

@Dragomir-Ivanov
Copy link
Author

Great @sum2000 , will test this soon. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v0.4.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants