Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an XMLNS Definition #11

Closed
dansiegel opened this issue Sep 17, 2020 · 2 comments
Closed

Add an XMLNS Definition #11

dansiegel opened this issue Sep 17, 2020 · 2 comments

Comments

@dansiegel
Copy link

Is your feature request related to a problem? Please describe.

Particularly as there is more than one Sharpnado package, any UI elements that would be referenced from XAML should be easily available with a single xmlns.

Describe the solution you'd like

<ContentPage xmlns:sharpnado="http://sharpnado.com">
  <sharpnado:MaterialFrame />
</ContentPage>

Describe alternatives you've considered

n/a

Additional context

Add a XmlnsDefinitionAttribute to all Sharpnado packages like:

[assembly: Xamarin.Forms.XmlnsDefinition("http://sharpnado.com", "Sharpnado.MaterialFrame")]
[assembly: Xamarin.Forms.XmlnsDefinition("http://sharpnado.com", "Sharpnado.AnotherClrNamespace")]

This helps to keep XAML cleaner particularly as you use an aggregate of types across your project as you do not have to remember which assembly something was in or what the clr namespace is.

@roubachof
Copy link
Owner

fixed by https://github.com/roubachof/Sharpnado.MaterialFrame/releases/tag/v1.1.3

@dansiegel
Copy link
Author

great to see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants