Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow binding stopped working in 1.2.0 version (worked in 1.1.0) #39

Closed
AlonRom opened this issue May 19, 2022 · 21 comments
Closed

Shadow binding stopped working in 1.2.0 version (worked in 1.1.0) #39

AlonRom opened this issue May 19, 2022 · 21 comments

Comments

@AlonRom
Copy link

AlonRom commented May 19, 2022

Platform (please complete the following information):

  • OS: Both
  • Device: all
  • Sdk vervion: all
  • Xamarin.Forms: Latest

Describe the bug
Shadow color binding stopped working in 1.2.0 version (worked in 1.1.0)

To Reproduce
Code:

   <sfList:SfListView
        Grid.Row="5"
        HorizontalOptions="CenterAndExpand"
        IsScrollBarVisible="False"
        IsScrollingEnabled="False"
        ItemSize="75"
        ItemTemplate="{StaticResource LedColorItemTemplate}"
        ItemsSource="{Binding LedsColorList}"
        SelectedItem="{Binding SelectedLed}"
        SelectedItemTemplate="{StaticResource SelectedLedColorItemTemplate}"
        SelectionMode="Single"
        VerticalOptions="StartAndExpand">
        <sfList:SfListView.LayoutManager>
            <sfList:GridLayout SpanCount="4" />
        </sfList:SfListView.LayoutManager>
    </sfList:SfListView>



  <DataTemplate x:Key="SelectedLedColorItemTemplate">
            <shades:Shadows
                Margin="0,2,0,0"
                BackgroundColor="White"
                CornerRadius="40"
                HorizontalOptions="Center">
                <shades:Shadows.Shades>
                    <shades:ImmutableShades>
                        <shades:Shade
                            BlurRadius="10"
                            Opacity="0.3"
                            Offset="5,5"
                            Color="{Binding ShadowColor}" />
                        <shades:Shade
                            BlurRadius="10"
                            Opacity="0.3"
                            Offset="-5,-5"
                            Color="{Binding ShadowColor}" />
                        <shades:Shade
                            BlurRadius="10"
                            Opacity="0.3"
                            Offset="-5,5"
                            Color="{Binding ShadowColor}" />
                        <shades:Shade
                            BlurRadius="10"
                            Opacity="0.3"
                            Offset="5,-5"
                            Color="{Binding ShadowColor}" />
                    </shades:ImmutableShades>
                </shades:Shadows.Shades>
                <border:SfBorder
                    BorderColor="{StaticResource FiordColor}"
                    BorderWidth="3"
                    CornerRadius="25"
                    HeightRequest="50"
                    HorizontalOptions="Center"
                    ShadowColor="{StaticResource ShadowGrayColor}"
                    VerticalOptions="Center"
                    WidthRequest="50">

                    <gradient:SfGradientView BackgroundBrush="{Binding BackgroundGradient}" />
                </border:SfBorder>
            </shades:Shadows>
        </DataTemplate>

Screenshots:
With 1.1.0:
good

With 1.2.0:
bad

@roubachof
Copy link
Owner

Hi 👋
If you want to mutate shades use them in a stack of shades not in a immutable shades collection

@AlonRom
Copy link
Author

AlonRom commented May 19, 2022

@roubachof do you have an example?
this exact code worked in the previous version.

@AlonRom
Copy link
Author

AlonRom commented May 19, 2022

@roubachof I changes to this:
shades:Shadows.Shades
shades:ShadeStack
<shades:Shade
BlurRadius="10"
Opacity="0.3"
Offset="5,5"
Color="{Binding ShadowColor}" />

and still not working on both platforms.

@roubachof
Copy link
Owner

Can you try to reproduce with the sample app ?

@AlonRom
Copy link
Author

AlonRom commented May 20, 2022

there you go:
https://github.com/AlonRom/ShadeBindingNotWorkingSample/tree/master/ShadeBindingNotWorkingSample

You can change to ShadeStack but it doesn't make any difference, only reducing the version helps.

@AlonRom
Copy link
Author

AlonRom commented May 24, 2022

@roubachof did you have a chance to check?
I can go to the previous version if this is something you recommend, although I prefer to be updated as much as possible.

@AlonRom
Copy link
Author

AlonRom commented May 29, 2022

@roubachof any chance to update regarding this issue?

@AlonRom
Copy link
Author

AlonRom commented Jun 14, 2022

@roubachof we are dependent on your package, can you please comment?

@roubachof
Copy link
Owner

I tried to look at your sample but it fails to restore the SyncFusion packages.

@roubachof
Copy link
Owner

image

@AlonRom
Copy link
Author

AlonRom commented Jun 14, 2022

@roubachof I removed the .nuget configuration file. can you please try again?

@roubachof
Copy link
Owner

Found the issue, however, since im not in a windows environnement I cannot make the nuget package...

@AlonRom
Copy link
Author

AlonRom commented Jun 14, 2022

@roubachof is it a matter of time? wait for it?

@AlonRom
Copy link
Author

AlonRom commented Jun 18, 2022

@roubachof ?

@roubachof
Copy link
Owner

Stay on the previous version until the release.

@AlonRom
Copy link
Author

AlonRom commented Jun 20, 2022

Do you have an estimate of when the next version will be published?

@AlonRom
Copy link
Author

AlonRom commented Jul 14, 2022

?

@AlonRom
Copy link
Author

AlonRom commented Oct 22, 2022

Hi @roubachof , I saw there is a 1.2.1. can you approve that the fix is included there?

@roubachof
Copy link
Owner

@AlonRom
Copy link
Author

AlonRom commented Jan 8, 2023

Hi @roubachof the issue is still not fixed in version 1.2.1

@roubachof
Copy link
Owner

I checked it with your sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants