Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Request: quad-backtick code blocks in markdown lexer #1439

Closed
Ravlen opened this issue Feb 12, 2020 · 2 comments · Fixed by #1442
Closed

Bug/Request: quad-backtick code blocks in markdown lexer #1439

Ravlen opened this issue Feb 12, 2020 · 2 comments · Fixed by #1442
Assignees
Labels
bugfix-request A request for a bugfix to be developed.

Comments

@Ravlen
Copy link
Contributor

Ravlen commented Feb 12, 2020

The markdown lexer should allow code blocks that have quad backticks, which is used when you need to encapsulate a triple backtick codeblock. For example, you can see it works fine in GitHub:

This is how you create a codeblock in markdown:

```yaml
---
one: Mark McGwire
two: Sammy Sosa
three: Ken Griffey
```

This is more text.

As you can see, it doesn't work with Rouge:

Screen Shot 2020-02-12 at 16 09 26

@Ravlen Ravlen added the enhancement-request A request for an enhancement to be developed. label Feb 12, 2020
@pyrmont pyrmont added bugfix-request A request for a bugfix to be developed. and removed enhancement-request A request for an enhancement to be developed. labels Feb 12, 2020
@pyrmont pyrmont self-assigned this Feb 12, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Feb 12, 2020

I think this should probably be marked as a bug. The CommonMark† spec provides that fenced code blocks can contain more than 3 tildes.

† I realise that CommonMark and Markdown are technically different but since CommonMark is the one with a proper spec, it seems logical to use it when trying to write a lexer.

@Ravlen
Copy link
Contributor Author

Ravlen commented Feb 12, 2020

Yeah, after I clicked submit I realized I should have started with the bug template, thanks for updating it for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix-request A request for a bugfix to be developed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants