Fix nesting of raw and verbatim tags in Jinja/Twig lexers #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stof Sorry this took so long! I realise that Twig hasn't supported |
|
Looks good to me. Thus, it will still allow highlighting Twig 1.x templates properly (and it should not cause issues for modern Twig templates, as it is very unlikely that projects will create a custom |
|
@stof Great! I'll merge it in now and it'll be part of v3.21.0 of Rouge. That will be released on Tuesday 14 July 🎉 |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
…#1552) The current Jinja lexer ends a `raw` or `verbatim` block when the lexer encounters either `endraw` or `endverbatim`. This behaviour is incorrect. The block should only end with a matching tag. This commit fixes that behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Jinja lexer ends a
raworverbatimblock when the lexer encounters eitherendraworendverbatim. This behaviour is incorrect. The block should only end with a matching tag.This fixes #1166.