Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAML key containing special characters #1667

Merged
merged 1 commit into from Jan 27, 2021
Merged

Fix YAML key containing special characters #1667

merged 1 commit into from Jan 27, 2021

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Jan 20, 2021 •
edited

The regex is lifted from the YamlLexer class in Pygments library (see more).

Before After
Screen Shot 2021-01-20 at 9 47 46 pm Screen Shot 2021-01-20 at 9 48 22 pm

Closes #778

Fix YAML key containing special characters
98afe79 
The regex is lifted from the YamlLexer class in Pygments library.
@tancnle tancnle marked this pull request as ready for review January 20, 2021 11:54
dblessing
dblessing approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@dblessing dblessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tancnle. I like the simplicity of this Regex opposed to the exist one.

spec/lexers/digdag_spec.rb Show resolved Hide resolved
@dblessing dblessing merged commit 4ba99f4 into rouge-ruby:master Jan 27, 2021
@tancnle tancnle deleted the fix-yaml-key-highlight branch January 27, 2021 22:57
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@mattt
Fix YAML key containing special characters (rouge-ruby#1667)
2bfffb8 
The regex is lifted from the YamlLexer class in Pygments library.
@gdubicki gdubicki mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblessing dblessing dblessing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML syntax highlighting for keys with periods and forward slashes
2 participants
@tancnle @dblessing