Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with Github workflow #1728

Merged
merged 1 commit into from Oct 19, 2021

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Aug 6, 2021

Travis has put in place a system of credits,
which has led most open source projects to migrate away from it.
Github offers a free, fast, and reliable CI solution which makes the choice a no-brainer.

I saw in #1690 that you were having issues with Travis.
Figured that the simplest solution was to switch to Github CI instead of a full move to Gitlab.
Also dropped support for versions < 2.5 following #1694

Travis has put in place a system of credits,
which has led most open source projects to migrate away from it.
Github offers a free, fast, and reliable CI solution which makes the choice a no-brainer.
@Geod24
Copy link
Contributor Author

Geod24 commented Aug 6, 2021

This will need to be whitelisted by a project maintainer. The workflow won't run until it's merged.
To see an example run, I created a PR in my fork: Geod24#1

@Geod24
Copy link
Contributor Author

Geod24 commented Sep 1, 2021

Ping @gfx @jneen

@tancnle
Copy link
Collaborator

tancnle commented Oct 3, 2021

Thanks, @Geod24. This is a good change since we get the CI from the same shop. AFAIK, Github Actions has usage limits (~ 2,000 minutes per month). @dblessing do you know what is the current limit on Travis?

@Geod24
Copy link
Contributor Author

Geod24 commented Oct 3, 2021

@tancnle Those limits only apply to private repositories.

@Geod24
Copy link
Contributor Author

Geod24 commented Oct 14, 2021

So can we get this merged @tancnle ?

@Geod24
Copy link
Contributor Author

Geod24 commented Oct 19, 2021

Ping @tancnle

@jneen
Copy link
Member

jneen commented Oct 19, 2021

Seems good to me.

@jneen jneen merged commit 3d5b989 into rouge-ruby:master Oct 19, 2021
@Geod24 Geod24 deleted the Geod24-patch-1 branch October 20, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants