Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny bug in scala lexer #374

Closed
htch opened this issue Jan 20, 2016 · 3 comments · Fixed by #1438
Closed

Tiny bug in scala lexer #374

htch opened this issue Jan 20, 2016 · 3 comments · Fixed by #1438
Assignees
Labels
bugfix-request A request for a bugfix to be developed.

Comments

@htch
Copy link

htch commented Jan 20, 2016

Stumbled upon a small wart in scala lexer: it treats closing parenthesis as a part of a preceding scala symbol, for example in this code sample:

StorageState.table(StorageState.NewUsers()).format(
  keyParams('app_id).asInstanceOf[String],
  keyParams('platform).asInstanceOf[String],
  keyParams('version).asInstanceOf[String],
  keyParams('scale).asInstanceOf[String],
  formattedToday
)

Relevant screenshot of the same code from gitlab that relies on rouge for its syntax highlighting and a paste in the rouge pastebin.

@stale
Copy link

stale bot commented Jun 19, 2019

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 19, 2019
@stale stale bot closed this as completed Jul 3, 2019
@anthony-cros
Copy link

This is still an issue as of today (the closing brackets is colored improperly), at least as used from Jekyll

@pyrmont
Copy link
Contributor

pyrmont commented Feb 12, 2020

Pretty sure the [^'] is the bug:

rule %r/'#{idrest}[^']/, Str::Symbol

I'm guessing that it's there to avoid matching against single-quoted strings but should probably be a negative lookahead.

@pyrmont pyrmont reopened this Feb 12, 2020
@stale stale bot removed the stale-issue There has been no activity for a year. label Feb 12, 2020
@pyrmont pyrmont added the bugfix-request A request for a bugfix to be developed. label Feb 16, 2020
@pyrmont pyrmont self-assigned this Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix-request A request for a bugfix to be developed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants