Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TOML's inline tables #826

Closed
have-a-boy opened this issue Nov 15, 2017 · 8 comments · Fixed by #1359
Closed

Add support for TOML's inline tables #826

have-a-boy opened this issue Nov 15, 2017 · 8 comments · Fixed by #1359

Comments

@have-a-boy
Copy link

Currently, inline tables from TOML seem to be highlighted entirely in red, aside from values and whitespace:

Key1 = {name = "foo", id = 5}  
"Key2" = {name = "bar"}

Githubs Linguist seems to highlight this correctly, for comparison:

[section]  
Key1 = {name = "foo", id = 5}  
"Key2" = {name = "bar"}

I'd love to see support for this spec added, tell me if there's any information I can provide to help.

@stale
Copy link

stale bot commented Jun 19, 2019

This contribution has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.

@stale stale bot added the stale-issue There has been no activity for a year. label Jun 19, 2019
@stale stale bot closed this as completed Jul 3, 2019
@Progdrasil
Copy link

this is still an issue, I use toml snippets in GitLab and it shows up similarly to the linked image
Screen Shot 2019-11-12 at 08 26 47

@pyrmont
Copy link
Contributor

pyrmont commented Nov 13, 2019

@Progdrasil I've submitted a PR that adds support for inline tables. Can you check if it looks like it works for you?

@pyrmont pyrmont reopened this Nov 13, 2019
@stale stale bot removed the stale-issue There has been no activity for a year. label Nov 13, 2019
@Progdrasil
Copy link

seems to work when i use rackup

@Progdrasil
Copy link

is there a way to test your branch on http://rouge.jneen.net/ ?

@pyrmont
Copy link
Contributor

pyrmont commented Nov 14, 2019

@Progdrasil There isn't, no, but if you've got the test site working with rackup, you can change the text that's displayed in the TOML visual sample by adding whatever you want to display to spec/visual/sample/toml.

@Progdrasil
Copy link

Yes that is what i did, seems to work

@pyrmont
Copy link
Contributor

pyrmont commented Nov 20, 2019

@Progdrasil Great. That should be enough. I'll merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants