Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp Lexer: Updates for Standard Library User-Defined Literals (chrono, complex) #1665

Merged
merged 1 commit into from Jan 19, 2021
Merged

cpp Lexer: Updates for Standard Library User-Defined Literals (chrono, complex) #1665

merged 1 commit into from Jan 19, 2021

Conversation

swheaton
Copy link
Contributor

  1. Add year (y) and date (d) std::chrono literals (introduced in C++20) - https://en.cppreference.com/w/cpp/symbol_index/chrono_literals
  2. Add std::complex literals (i, il, if) - https://en.cppreference.com/w/cpp/symbol_index/complex_literals
  3. Fix to allow digit separators in std::chrono and std::complex literals

Copy link
Collaborator

@dblessing dblessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swheaton Thanks for your contribution. I left one item for your consideration.

lib/rouge/lexers/cpp.rb Show resolved Hide resolved
@dblessing dblessing added the author-action The PR has been reviewed but action by the author is needed label Jan 19, 2021
@dblessing dblessing merged commit 26af041 into rouge-ruby:master Jan 19, 2021
@dblessing dblessing removed the author-action The PR has been reviewed but action by the author is needed label Jan 19, 2021
@swheaton
Copy link
Contributor Author

Thanks for review!

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
…rono literals with digit separator (rouge-ruby#1665)

Co-authored-by: Stuart <stuart.wheaton@jhuapl.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants