Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems bot to work on IE11 or Edge #47

Closed
zoosky opened this issue Mar 27, 2018 · 9 comments
Closed

Seems bot to work on IE11 or Edge #47

zoosky opened this issue Mar 27, 2018 · 9 comments

Comments

@zoosky
Copy link

zoosky commented Mar 27, 2018

  • not
@AddictArts
Copy link

It can be fixed with mixed results, for example rc.path did not work, no Path2D support?

// I was able to add or install dev dependencies babel-cli, ... listed below and then the babel-polyfill
 "devDependencies":
    "babel-cli": "^6.26.0",
    "babel-preset-es2015": "^6.24.1",
    "babel-preset-es2017": "^6.24.1",
    "uglify-js": "^3.3.16"

  "dependencies":
    "babel-polyfill": "^6.26.0"

And you need a suitable babelrc

{
  "presets": [ "es2017", "es2015" ]
}

And then a way to run babel and uglify, for example I added to package.json

    "babel-es5": "babel dist/rough.js -o dist/rough.es5.js",
    "minify-u": "uglifyjs dist/rough.es5.js -o dist/rough.min.js",

@OSUblake
Copy link

OSUblake commented Apr 9, 2018

It can be fixed with mixed results, for example rc.path did not work, no Path2D support?

IE11 does not support Path2D. Edge does, but there is an issue with SVG path data.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8438884/

@pshihn
Copy link
Collaborator

pshihn commented Apr 9, 2018

Path2D is only used when filling with hachure styles in paths. Not in issue for other shape constructs.
I want to move away from Path2D anyway because it will solve some other minor issues as well. Working on some good algorithms that may work as an alternative

@pshihn
Copy link
Collaborator

pshihn commented Aug 3, 2018

The build now includes an ES5 version.

@zoosky
Copy link
Author

zoosky commented Aug 3, 2018

Cool

@Nalca
Copy link

Nalca commented Oct 2, 2018

I tried the ES5 version and it does not work on IE11.
Not when the keyword async is present. It's a ES2017 keyword.

@pshihn
Copy link
Collaborator

pshihn commented Oct 2, 2018

@Nalca you're right
I need to run this through babel to fix those. May need a Promise polyfill as well.
PRs welcome. Not sure when I'll get a chance.

@AddictArts
Copy link

I used the babel-polyfill to fix the missing "async" after running into it. Simple add to my project build.

@pshihn
Copy link
Collaborator

pshihn commented Apr 15, 2020

Removed Path2D dependency.

@pshihn pshihn closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants