Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wired-input not updating value property, value attribute and not firing onchange #123

Closed
MarcSkovMadsen opened this issue Mar 5, 2020 · 2 comments

Comments

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Mar 5, 2020

My Pain

I'm trying to add support for the Wired Elements to Panel, a framework for creating awesome analytics apps in Python.

When using the wired-input and writing "abcde" + enter the following does not happen

  1. The value attribute does not change
  2. The value property does not change
  3. The onchange event does not fire.

I would have expected 2. + 3. and maybe 1.

Instead I can see that the textinput.value changes

image

Solution

As a minimum update the value property. Consider fixing some of the other things as well.

Additional Context

Im using Wired by including

<script src="https://unpkg.com/@webcomponents/webcomponentsjs@2.2.7/webcomponents-loader.js"></script>
<script src="https://wiredjs.com/dist/showcase.min.js"></script>
@MarcSkovMadsen
Copy link
Author

I've been able to find a work around for my use case. But I still believe it's important in general to solve.

@pshihn
Copy link
Contributor

pshihn commented Jun 20, 2020

I've tested this in v2.1.1 and both points 2 and 3 seem to have been fixed.
Attribute not changing is by design. Like value is not reflected to the attribute

@pshihn pshihn closed this as completed Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants