New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wired-card calls non-existing this._requestRender() #31
Comments
Sure enough, lit-element changed their API in 0.5.2 and that version is getting picked up. They should have used 0.6 for breaking changes fo semVer to work. |
Resolved by upgrading to latest lit-element and adjusting code accordingly: Fix in v0.6.5 |
Thanks 🙂 Now featuring Wired JS in the custom cards example for Home Assistant https://developers.home-assistant.io/docs/en/lovelace_custom_card.html#defining-your-card |
@balloob looks cool |
<wired-card>
callsthis._requestRender()
when theslotchange
event is fired. However, that method does not exist on the elemnt.https://github.com/wiredjs/wired-elements/blob/da4f150c04a336df41e228b794f14663f54b6d6f/packages/wired-card/wired-card.js#L55
<wired-card>
depends on Lit Element^0.5.1
. I've checked the source code of Lit Element, and it looks like they renamed it tothis.requestRender()
:https://github.com/Polymer/lit-element/blob/fb90e7640777cab01c9eac2006cde558c34b041d/src/lit-element.ts#L261
(I did a quick search and noticed a few more places that call
_requestRender()
.I was using
<wired-card>
by importing it form unpkg:The text was updated successfully, but these errors were encountered: