Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar too high when transparent navigationbar and attachShy() #140

Closed
Nolanus opened this issue Apr 8, 2016 · 4 comments
Closed

Snackbar too high when transparent navigationbar and attachShy() #140

Nolanus opened this issue Apr 8, 2016 · 4 comments
Labels

Comments

@Nolanus
Copy link

Nolanus commented Apr 8, 2016

device-2016-04-08-093042

        <android.support.design.widget.FloatingActionButton
            android:id="@+id/activity_main_fab"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="bottom|end"
            android:layout_marginBottom="64dp"
            android:layout_marginRight="16dp"
            android:clickable="true"
            android:src="@drawable/my_drawable"
            app:fabSize="normal"
            app:layout_behavior="com.example.ui.component.BottomNavigationFloatingActionButtonBehavior"
            />

When the bottomBar is visible, the snackbar looks good.

@NikolaDespotoski
Copy link
Contributor

@Nolanus @roughike Since it is not precised in the guidelines how bottom nav should behave when snackbar is shown, rather than snackbars being above bottom nav, I have deliberately made the snackbar not go above. Also there is another behavior which shows both snackbar and bb and hides bb when snackbar is dismissed if previously bb was hidden.

@Nolanus
Copy link
Author

Nolanus commented Apr 9, 2016

The "default" behavior of the SnackBar with translucent statusBar (inside a CoordinatorLayout) is to be shown above the navigation buttons. That doesn't look nice from my point of view, but it's this libraries task to fix that.
Therefore I suggest the additional height that is given to the SnackBar in BottomNavigationWithSnackbar layout behavior should be reset while the BottomBar is hidden to restore the "default" behavior.

If a scrolling happens while the SnackBar is shown, it would be awesome if the height could be added again "on the fly", otherwise overlaying the SnackBar with the re-appearing BottomBar would be ok.

@roughike
Copy link
Owner

The BottomBar is now a regular View and should behave properly starting from 2.0 and up.

See here for instructions for shy behavior

@vipulasri
Copy link

@roughike still same issue even after 2.0, I am using latest version i.e 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants