Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attributes from manifest's Application #52

Closed
gowong opened this issue Mar 19, 2016 · 1 comment
Closed

Remove attributes from manifest's Application #52

gowong opened this issue Mar 19, 2016 · 1 comment

Comments

@gowong
Copy link

gowong commented Mar 19, 2016

A library shouldn't declare unnecessary attributes on the Application as doing so will automatically merge them into app's manifest. For example, an app that doesn't declare supportsRtl will now have it set to true after importing this library, even though the default value should be false.

BottomBar/bottom-bar/src/main/AndroidManifest.xml

<application
        android:allowBackup="true"
        android:label="@string/app_name"
        android:supportsRtl="true">

</application>
@roughike
Copy link
Owner

Fixed in library version 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants