New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SDK deps to 5.5.0 and remove deprecated SDK methods and usages #169
Conversation
This is great, thanks for the solution! @sroddy The current FB SDKs this plugin is using aren't working on iOS 13 + Can confirm that this works with iOS 13. |
To anyone that wants to use this while it isn't merged, just update your
|
working well ! thanks my brother ! |
I am still getting the alert from Apple regarding the UIWebView. The issue comes from a dependency specified in the example @sroddy Possibly, for this PR to be perfect, the podfile should be updated as well. |
Seems like this is an issue on |
@gildaswise don't recall using that plugin though. Strange anyway that example dependencies are also imported? |
Nope, the dependencies from the examples are not imported and also the podfile is ignored. The only thing that matters is the podspec which I’ve correctly updated. |
Yes, absolutely right. The warning from apple regarding the UIWebView comes from another dependency. |
Awesome work, @sroddy! One question though, does this address the issue of UIWebView API being deprecated? Thanks! |
Awesome job, thanks! Just needed this in our app right now. We'll test it in production™ and push into Pub in a couple days. |
@sroddy I'll fix the Travis build soon - don't mind the errors. I'm using a centuries old |
Great news! We are already using it in production (Freska App), so far, no problems at all. |
Be sure to update to my latest commit because on Android we experienced some crashes due to an error that Facebook fixed in version 5.5.1 |
This was a great PR. Thanks! Feel free to reach out on any future issues you might have. |
5.5.0
loginWithPublishPermissions
and renamedloginWithReadPermission
tologin
behavior
parameter is now ignored on iOS as it is not supported anymore by the Facebook Login SDK9.0