Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK deps to 5.5.0 and remove deprecated SDK methods and usages #169

Merged
merged 5 commits into from Sep 22, 2019

Conversation

sroddy
Copy link
Contributor

@sroddy sroddy commented Sep 2, 2019

  • Update Android & iOS Facebook Login dependencies to 5.5.0
  • Removed deprecated method loginWithPublishPermissions and renamed loginWithReadPermission to login
  • The behavior parameter is now ignored on iOS as it is not supported anymore by the Facebook Login SDK
  • Bump iOS deployment target to 9.0

@sroddy sroddy changed the title Bump SDK deps to 5.5.0 and remove depracated SDK methods and usages Bump SDK deps to 5.5.0 and remove deprecated SDK methods and usages Sep 4, 2019
@astonyao
Copy link

astonyao commented Sep 6, 2019

* Update Android & iOS Facebook Login dependencies to `5.5.0`

* Removed deprecated method `loginWithPublishPermissions` and renamed `loginWithReadPermission` to `login`

* The `behavior` parameter is now ignored on iOS as it is not supported anymore by the Facebook Login SDK

* Bump iOS deployment target to `9.0`

This is great, thanks for the solution! @sroddy

The current FB SDKs this plugin is using aren't working on iOS 13 +

Can confirm that this works with iOS 13.

@gildaswise
Copy link

To anyone that wants to use this while it isn't merged, just update your pubspec.yaml to:

  flutter_facebook_login:
    git:
      url: https://github.com/roughike/flutter_facebook_login.git
      ref: 16ecb49

@wish4129
Copy link

To anyone that wants to use this while it isn't merged, just update your pubspec.yaml to:

  flutter_facebook_login:
    git:
      url: https://github.com/roughike/flutter_facebook_login.git
      ref: 16ecb49

working well ! thanks my brother !

@jonyas
Copy link

jonyas commented Sep 12, 2019

I am still getting the alert from Apple regarding the UIWebView. The issue comes from a dependency specified in the example podfile.locknamed Bolts.

@sroddy Possibly, for this PR to be perfect, the podfile should be updated as well.

@gildaswise
Copy link

I am still getting the alert from Apple regarding the UIWebView. The issue comes from a dependency specified in the example podfile.locknamed Bolts.

Possibly, for this PR to be perfect, the podfile should be updated as well.

Seems like this is an issue on firebase_auth, rather than this plugin: flutter/flutter#39470 (comment)

@jonyas
Copy link

jonyas commented Sep 12, 2019

@gildaswise don't recall using that plugin though.
I'll fork this tomorrow and give it a try after cleaning that podfile.

Strange anyway that example dependencies are also imported?

@sroddy
Copy link
Contributor Author

sroddy commented Sep 13, 2019

Nope, the dependencies from the examples are not imported and also the podfile is ignored. The only thing that matters is the podspec which I’ve correctly updated.

@jonyas
Copy link

jonyas commented Sep 17, 2019

Yes, absolutely right. The warning from apple regarding the UIWebView comes from another dependency.
We've been testing this update and is working great, should be ready to merge.

@chynnasevilleno
Copy link

Awesome work, @sroddy! One question though, does this address the issue of UIWebView API being deprecated? Thanks!

@roughike
Copy link
Owner

Awesome job, thanks! Just needed this in our app right now.

We'll test it in production™ and push into Pub in a couple days.

@roughike
Copy link
Owner

@sroddy I'll fix the Travis build soon - don't mind the errors. I'm using a centuries old .travis.yml and it needs to be updated a little bit.

@jonyas
Copy link

jonyas commented Sep 19, 2019

Great news! We are already using it in production (Freska App), so far, no problems at all.

@sroddy
Copy link
Contributor Author

sroddy commented Sep 20, 2019

Be sure to update to my latest commit because on Android we experienced some crashes due to an error that Facebook fixed in version 5.5.1

@roughike roughike merged commit 55e2067 into roughike:master Sep 22, 2019
@roughike
Copy link
Owner

This was a great PR. Thanks! Feel free to reach out on any future issues you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants