Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Code review #52
This is the best format I could think of, to easily get embedded code snippets and links, and some notion of "actions".
Please note that my experience with mobile development only amounts to 1 React Native app, 1 iOS App, 0.1 Android app – and I did a bit of Dart once. I might be criticising things that are well-established conventions in the mobile / Dart world
Things that are missing
I'm not sure they really are missing
I imagine these might come for free with the SDK though.
In no particular order, except for this first section,
File structure & naming
Did I mention the code actually is very readable?
This is by far the most insightful code review I've ever received. Thanks a lot, really!
I'll address those points when I can, most likely tomorrow.
Update: had to do a release finally, incorporated some of those changes before that. Will address all of them when I have the time. Thanks again!
Thanks for sharing your code ! Amazing project, really !
You should take a look at https://flutter.io/cookbook/networking/background-parsing/, it could be interesting to implement it.
@anasbud Thanks, glad you like it!
I'll create an issue ticket about parsing in a separate Isolate, and see if it makes sense here. The last time I tried it, which was in January, it seemed that at least parsing JSON was fast enough. IIRC, the overhead of switching from main to background Isolate took longer than parsing the JSON, and there wasn't any UI thread stutter to begin with.
Might be that some small optimizations could add up and in this project, it would actually make a lot of sense, but you never know until you investigate. :)
Agreed. Amazing code review, and really great work! I generally concur with what's been said, and would suggest only minor changes.
Adding further comments: