Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd the tmdb_config.dart file with a placeholder api key #14

Closed
roughike opened this issue Apr 7, 2018 · 0 comments
Closed

Readd the tmdb_config.dart file with a placeholder api key #14

roughike opened this issue Apr 7, 2018 · 0 comments
Assignees
@roughike
Labels
Priority: Critical Status: Not started/Idle The issue is idle and isn't currently being worked on by anyone. Type: Bug

Comments

@roughike
Copy link
Owner

roughike commented Apr 7, 2018

The project can't be built in its current state since it assumes that tmdb_config.dart is present. That file is omitted on purpose so that an actual TMDB API key isn't accessible to anyone.

Add lib/tmdb_config.dart with contents something like this:

class TMDBConfig {
  static final String apiKey = '<YOUR API KEY HERE>';
}

Also, make it fallback nicely; if there's no valid API key, the app shouldn't crash and the actor names shouldn't get stuck to Loading....
@roughike roughike added Priority: Critical Type: Bug Status: Not started/Idle The issue is idle and isn't currently being worked on by anyone. labels Apr 7, 2018
@roughike roughike self-assigned this Apr 7, 2018
@roughike roughike mentioned this issue Apr 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roughike roughike

Labels
Priority: Critical Status: Not started/Idle The issue is idle and isn't currently being worked on by anyone. Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roughike