Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null-safety #16

Merged
merged 1 commit into from Apr 12, 2021
Merged

Migrate to null-safety #16

merged 1 commit into from Apr 12, 2021

Conversation

JonasWanke
Copy link
Contributor

I tried to keep the methods as close to the pre-null-safe-versions as possible, though maybe some of it should be changed with regards to #3.

This migration includes a breaking change: As in the null-safe version of shared_preferences, setters no longer accept null to mean removing values. (remove(key) can be used instead.)

@roughike
Copy link
Owner

roughike commented Mar 8, 2021

Hey! Thanks for the PR, good stuff. My time is limited, but I'll try to review when I can.

For those who want to start using this today:

pubspec.yaml

dependencies:
  # ...
  streaming_shared_preferences:
    git:
      url: https://github.com/roughike/streaming_shared_preferences
      ref: a460743

@josh-burton
Copy link

This is becoming a real blocker in a lot of projects. Would be great to see this merged

@JonasWanke JonasWanke mentioned this pull request Apr 6, 2021
Copy link
Owner

@roughike roughike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@roughike roughike merged commit b4894eb into roughike:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants