Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange behavior from 'n' and 'p' keys when near collapsed threads #7

Open
mankoff opened this issue Feb 17, 2021 · 7 comments
Open

Comments

@mankoff
Copy link

mankoff commented Feb 17, 2021

Navigating the header view with 'n' and 'p' no longer works perfectly.

'n' moves right 1 when 1 line below a ">".
'p' from below a ">" moves to end of line with ">"

@rougier
Copy link
Owner

rougier commented Feb 17, 2021

I confirm. I'm navigating with up/down arrows which work fine s maybe the native binding for n/p is different. I suspect make you point on an hidden child and this might be the reason.

@emacsomancer
Copy link

I think the one issue I'm having is probably the same one as this:

if I navigate in headers view to a folded thread (say by arrows keys or mouse click) and view the first message in the folded thread (without unfolding), then pressing =n= moves me to the next message in the next in the =Article= buffer but the indicator from the =mu4e-headers= buffer just disappears.

Would there be a way of having navigation beyond the first message of a folded thread automatically trigger the unfolding of that thread?

@rougier
Copy link
Owner

rougier commented Feb 18, 2021

That might be doable. If you look at the toggle-at-point code, I think you can probably adapt it.

@maxmahlke
Copy link

I noticed the same scrolling issue as described in the first post, using the j and k keys in evil-mode. Unbinding the keys from the original mu4e-headers-next and mu4e-headers-previous and rebinding to the regular evil-next-line and evil-previous-line fixed it.

  (define-key mu4e-headers-mode-map (kbd "<normal-state> j")     nil)
  (define-key mu4e-headers-mode-map (kbd "<normal-state> j")     'evil-next-line)
  (define-key mu4e-headers-mode-map (kbd "<normal-state> k")     nil)
  (define-key mu4e-headers-mode-map (kbd "<normal-state> k")     'evil-previous-line)

@rougier
Copy link
Owner

rougier commented Feb 28, 2021

Do you what the difference between the mu4e-heders-next and evil-next-line?

@maxmahlke
Copy link

From the documentation, it seems that mu4e-headers-next works based on the message headers, not on the lines themselves. I assume that the folded thread counts as two messages but just one line, so evil-next-line skips the hidden message correctly.

evil-next-line

Documentation
Move the cursor COUNT lines down.

mu4e-headers-next

Documentation
Move point to the next message header.

@rougier
Copy link
Owner

rougier commented Mar 4, 2021

Thanks. Skipping hidden lines make sense. I need to implement this (or just copy the code from evil-next-line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants