New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When minibuffer window is active, background modeline in (previously) active window is off #45
Comments
I do not modify the fringe, that might be the reason. But with vanilla emacs / default modeline, you have the same problem, do you? |
I'm not sure I understand. In vanilla emacs with the default modeline, the modeline has a constant background even when the fringe has a different color from the default background. E.g., trying out (fringe-mode '(4 . 80)) and then calling Note the difference with what happens after installing The background only looks like this when the minibuffer is active. Otherwise, it looks as you'd expect: From what I can tell, the problem is that when the minibuffer is active, part of the modeline is using the And changing the color of the fringe doesn't change the color of the segment of the modeline right above the right fringe, e.g.: |
I see. I think the problem is that the modeline stops at the right border instead of the right fringe border. I'll look into that. Or if you want to experiment, you can have a look at line 490 and pixel specifications. Maybe replacing |
@apc see if you can reproduce it with my fork: https://github.com/aaronjensen/nano-modeline/blob/master/nano-modeline.el I don't vary the background color at all, so I don't know if I have the problem and just can't see it or not. |
@aaronjensen yes, I get the same behavior. From what I can tell, the problem is visible only when the faces |
Isn't it the window divider that you see? Can you try to change the |
Can you try aligning with |
I might be fixed with the new simpler branch. Coudl you give it a try? |
I'm not sure what controls the look of the modeline in the active window when the minibuffer window is active, but something seems off. I think the issue is that the right fringe background color is not modified, unlike the background color of the rest of the modeline:
(This is using the built-in dichromancy theme, with
fringe-mode
set todefault
.)It's even more noticeable if you increase the right fringe (here I set the right fringe to 80):
I can reproduce in vanilla emacs after installing nano-modeline (by calling
package-install
) and evaluating the following buffer:(For clarity, the screenshot is taken after splitting the frame in two and calling
switch-to-buffer
.)The text was updated successfully, but these errors were encountered: