Add Comments and Fix rotation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. correction 1-1. tangent and orthogonal vectors of PC1 1-2. "broken" figures on screen. (file output was fine) 2. variables - whenever any variables are redefined, created as a new name for readability 3. add comments - short descriptions on each variables (ex. L60, # d : max. distance between P0 and Z1) - short descriptions on code (ex. L119, # preparation of the histogram Axes)
Add some more comments Fix: histogram text rotation
little bit more correction
|
Many, many thanks for your fix. I realized the code is quite complex and I imagine it was not easy to fix. Well done. |
|
Thanks for accepting my pull request!
At the moment I'm too busy to work on another code, but I'm searching for
the next one.
Maybe the next will be done near the Christmas season.
How is the negotiation about translation going on? Was there any discussion
with Hanbit media?
Best regards,
Jehyun.
…On Wed, 15 Dec 2021 at 20:29, Nicolas P. Rougier ***@***.***> wrote:
Many, many thanks for your fix. I realized the code is quite complex and I
imagine it was not easy to fix. Well done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUZLZIN3IA425N5QUKYWT3URB3Z5ANCNFSM5JGPU3OQ>
.
|
|
@jehyunlee Yes, this told me they were trying to contact you actually. I'll forward you email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correction
1-1. tangent and orthogonal vectors of PC1
1-2. "broken" figures on screen. (file output was fine)
variables
whenever any variables are redefined, created as a new name for readability
add comments
short descriptions on each variables (ex. L60, # d : max. distance between P0 and Z1)
short descriptions on code (ex. L119, # preparation of the histogram Axes)