Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect description and links to the code for Figures 2.3-2.5 (Chapter 2, pages 23-25) #64

Closed
labdmitriy opened this issue Jul 12, 2022 · 5 comments

Comments

@labdmitriy
Copy link
Contributor

labdmitriy commented Jul 12, 2022

Hi @rougier,

The links to the code for Figures 2.3-2.5 have the name coordinates/transform‐*.py and URL https://github.com/rougier/scientific-visualization-book/blob/master/code/coordinates/transform-*.py, but the files have the name transforms-*.py, so probably the following will be correct:
Name - coordinates/transforms‐*.py
URL - https://github.com/rougier/scientific-visualization-book/blob/master/code/coordinates/transforms-*.py

Also for Figure 2.5 there is the same description as for Figure 2.3 (except for file name):

Figure 2.3
Axes boundaries in polar projection using a transform from normalized data co‐
ordinates to data coordinates (coordinates/transform‐polar.py).

Figure 2.5
Axes boundaries in polar projection using a transform from normalized data co‐
ordinates to data coordinates (coordinates/transform‐blend.py).

It seems that Figure 2.5 has incorrect description.

Thank you.

@labdmitriy labdmitriy changed the title Incorrect link to Figure 2.3 (Chapter 2, page 23) Incorrect links to Figures 2.3-2.5 (Chapter 2, pages 23-25) Jul 12, 2022
@labdmitriy labdmitriy changed the title Incorrect links to Figures 2.3-2.5 (Chapter 2, pages 23-25) Incorrect links to the code for Figures 2.3-2.5 (Chapter 2, pages 23-25) Jul 12, 2022
@labdmitriy labdmitriy changed the title Incorrect links to the code for Figures 2.3-2.5 (Chapter 2, pages 23-25) Incorrect description and links to the code for Figures 2.3-2.5 (Chapter 2, pages 23-25) Jul 12, 2022
@rougier
Copy link
Owner

rougier commented Jul 13, 2022

You're right, it's completely wrong. I think it was correct at some point, I need to track changes on commit.

@labdmitriy
Copy link
Contributor Author

Hi @rougier,

I found that there are 2 more links with transform-* names in coordinates.rst file:

Axes boundaries in polar projection using a transform from normalized data coordinates to data coordinates (:source:coordinates/transform-polar.py). labelfig-transforms-polar

Using transforms to position precisely a text over a plot. Top panel uses normalized data coordinates (0.1,0.1), bottom panel uses normalized data coordinates (0.0,0.0) plus an offset (10,10) expressed in figure coordinates (:source:coordinates/transform-letter.py). labelfig-transforms-letter

Is it correct?

Thank you.

@rougier
Copy link
Owner

rougier commented Jul 16, 2022

I think I fixed them but maybe I forgot some. Best would be to rename transforms-* to transform-* in both text and filename.

@labdmitriy
Copy link
Contributor Author

Hi @rougier,

It is not a problem to fix it, just to clarify (because before we renamed the links and names from transform-* to transforms-*) - do I understand correctly that I should rename all the links and names from transforms-* to transform-*, and also the corresponding files in the folder with code?

Thank you.

@rougier
Copy link
Owner

rougier commented Jul 25, 2022

I think transforms-* is the right form and this the prefix for all the scripts now. Best is to only modify in the book but I think I've fixed them a few commits ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants