Code for Figure 2.3 from the book doesn't match the image (Chapter 2, pages 22-23)

[labdmitriy]

Hi @rougier,

If we use the code for the Figure 2.3 from the book, then the border will be inside data coordinates, not outside as expected, and with different tick labels (specifying the code from the book before resolving #63):

fig = plt.figure(figsize=(5, 5), dpi=100)
ax = fig.add_subplot(1, 1, 1, projection='polar')

FC_to_DC = ax.transData.inverted().transform
NDC_to_FC = ax.transAxes.transform
NDC_to_DC = lambda x: FC_to_DC(NDC_to_FC(x))

P = NDC_to_DC([[0,0], [1,0], [1,1], [0,1], [0,0]])

plt.plot(P[:,0], P[:,1], clip_on=False, zorder=-10
         color="k", linewidth=1.0, linestyle="--", )
plt.scatter(P[:-1,0], P[:-1,1],
            clip_on=False, facecolor="w", edgecolor="k")
plt.show()

But the code in Python file is correct.
I compared the code and find that for displaying the figure there are 2 additional lines in Python file:

scientific-visualization-book/code/coordinates/transforms-polar.py

Line 12 in a8eeebb

ax.set_ylim(-1, 1), ax.set_yticks([-1, -0.5, 0, 0.5, 1])

scientific-visualization-book/code/coordinates/transforms-polar.py

Line 30 in a8eeebb

plt.tight_layout()

And the first line (setting the limits for y-axis and specifying tick labels) is required to get expected figure.

Thank you.

[rougier]

Thanks, can you make a PR?