Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to loosen the dependency on textblob #10

Open
Agnes-U opened this issue Nov 15, 2022 · 2 comments
Open

Suggest to loosen the dependency on textblob #10

Agnes-U opened this issue Nov 15, 2022 · 2 comments

Comments

@Agnes-U
Copy link

Agnes-U commented Nov 15, 2022

Hi, your project CorrectLy(commit id: b682254) requires "textblob==0.15.1" in its dependency. After analyzing the source code, we found that the following versions of textblob can also be suitable, i.e., textblob 0.9.0, 0.9.1, 0.10.0, 0.11.0, 0.11.1, 0.12.0, 0.13.0, 0.13.1, 0.14.0, 0.15.0, 0.15.2, 0.15.3, 0.16.0, 0.17.0, 0.17.1, since all functions that you directly (1 APIs: textblob.blob.TextBlob.init) or indirectly (propagate to 5 textblob's internal APIs and 0 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on textblob from "textblob==0.15.1" to "textblob>=0.9.0,<=0.17.1". This will improve the applicability of CorrectLy and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on textblob?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

@rounakdatta
Copy link
Owner

@Agnes-U thanks for pointing out! Feel free to raise a PR which I can merge, but otherwise I'm not planning to maintain this project - so it might be breaking already. If the project seems useful to you, please feel free to progress in your respective fork. :)

@Agnes-U
Copy link
Author

Agnes-U commented Dec 7, 2022

Thanks for your reply! #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants