You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Good finding, but maybe would be better to move the code calling refresh in index.php a little bit earlier, e.g. before reading func.inc file, so exec_hook() here wouldn't be needed.
The reason will be displayed to describe this comment to others. Learn more.
Aleksander Machniak wrote:
Good finding, but maybe would be better to move the code calling refresh in
index.php a little bit earlier, e.g. before reading func.inc file, so
exec_hook() here wouldn't be needed.
It was reported on the kolab-devel mailing list. I don't know which
solution would be better. The mail task is currently the only one, defining
an action map for 'refresh' thus the current solution works...
~Thomas
The reason will be displayed to describe this comment to others. Learn more.
Yes, your solution works, but... The problem is (was) that line 294 in index.php is not executed because of $OUTPUT->send() at the end of check_recent.inc file. So, another solution is to exec refresh hook (in index.php) before execution is stopped by any action. The third option is to remove $OUTPUT->send() in check_recent.inc.
65de001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good finding, but maybe would be better to move the code calling refresh in index.php a little bit earlier, e.g. before reading func.inc file, so exec_hook() here wouldn't be needed.
65de001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
65de001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, your solution works, but... The problem is (was) that line 294 in index.php is not executed because of $OUTPUT->send() at the end of check_recent.inc file. So, another solution is to exec refresh hook (in index.php) before execution is stopped by any action. The third option is to remove $OUTPUT->send() in check_recent.inc.