IE can't download attach file #1836

Closed
rcubetrac opened this Issue Sep 30, 2008 · 9 comments

1 participant

@rcubetrac

Reported by joungkyun on 30 Sep 2008 17:40 UTC as Trac ticket #1485430

roundcubemail is solved http://support.microsoft.com/kb/323308 issue
with follow code

:: webmail/program/steps/mail/get.inc 78 lines

    if (isset($_SERVER[     {
      header('Pragma: ');
      header('Cache-Control: ');
      }

But, some php build without $_SERVER'HTTPS')
), so, this code is useless. so fixed follows

if (preg_match('/MSIE/', $_SERVER[&& (isset($_SERVER['HTTPS']('HTTP_USER_AGENT']))) || $_SERVER['SERVER_PORT'] == '443'))

Migrated-From: http://trac.roundcube.net/ticket/1485430

@rcubetrac

Owner changed by @alecpl on 30 Sep 2008 18:20 UTC

=> none

@rcubetrac

Milestone changed by @alecpl on 30 Sep 2008 18:20 UTC

later => 0.2-stable

@rcubetrac

Comment by tensor on 30 Sep 2008 22:16 UTC

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

@rcubetrac

Comment by joungkyun on 1 Oct 2008 05:33 UTC

Replying to tensor:

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

I tested follow environments

    Server: PHP 5.2.6 + SSL (HTTPS connection)

    1. Windows Vista SP1 + IE 7 (Korean)
    2. Windows XP SP3 + IE 6 (Korean)
    3. Windows XP SP3 + IE 7 (Korean)

I have download problem all case. And, my php don't have HTTPS variable in _SERVER gloable variables. So, After applied my patch, I solved attache file download problem.

@rcubetrac

Comment by joungkyun on 1 Oct 2008 05:48 UTC

Replying to joungkyun:

Replying to tensor:

Replying to joungkyun:
What OS and IE version do you use?
Implementing this patch as is may harm other user's IE (including IE 7 and fixed IE 6 versions). IE 5.5 and below are not supoorted by RC.

I tested follow environments

    Server: PHP 5.2.6 + SSL (HTTPS connection)

    1. Windows Vista SP1 + IE 7 (Korean)
    2. Windows XP SP3 + IE 6 (Korean)
    3. Windows XP SP3 + IE 7 (Korean)

I have download problem all case. And, my php don't have HTTPS variable in _SERVER gloable variables. So, After applied my patch, I solved attache file download problem.

Firefox 2/3 has no problems whether upper header is set or not set.

@rcubetrac

Comment by tensor on 1 Oct 2008 12:44 UTC

joungkyun, can you provide a test account at your mail server? you can send me private email to dennis at nikolaenko dot ru

Are you using 0.1.1 RC version?

@rcubetrac

Comment by joungkyun on 1 Oct 2008 18:21 UTC

Replying to tensor:

joungkyun, can you provide a test account at your mail server? you can send me private email to dennis at nikolaenko dot ru

send to dennis at nikolaenko dot ru.

Are you using 0.1.1 RC version?

I'm using 0.1.1 stable + http://trac.roundcube.net/ticket/1484991 patch

@rcubetrac

Comment by tensor on 2 Oct 2008 19:53 UTC

I tested joungkyun's server, it runs 0.1.1.
This issue has been definitely solved in the trunk. This ticket can be closed. As the 0.2-stable release is going to be released soon, I believe it is not worth the trouble to backport to 0.1 series.

@rcubetrac

Status changed by @alecpl on 3 Oct 2008 06:09 UTC

new => closed

@rcubetrac rcubetrac closed this Oct 3, 2008
@rcubetrac rcubetrac added this to the 0.2-stable milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment