Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundcube Error 501 Error loading template ... #3987

Closed
rcubetrac opened this issue Nov 3, 2012 · 5 comments
Closed

Roundcube Error 501 Error loading template ... #3987

rcubetrac opened this issue Nov 3, 2012 · 5 comments

Comments

@rcubetrac
Copy link

Reported by rosali on 3 Nov 2012 07:43 UTC as Trac ticket #1488787

rcube_template.php around line 427 (RC 0.8.2):

Please add a hook before throwing the error to give plugin programmers the chance to handle this exception themselves.

Thanks!

Migrated-From: http://trac.roundcube.net/ticket/1488787

@rcubetrac
Copy link
Author

Comment by @alecpl on 3 Nov 2012 19:15 UTC

I don't like to add too many hooks and this case is not really something I'd like to handle with hook.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 3 Nov 2012 19:15 UTC

0.9-beta => later

@rcubetrac
Copy link
Author

Comment by rosali on 3 Nov 2012 20:12 UTC

OK, but what's your suggestion to handle things if a template for a skin is missing? May be the render_page hook should be moved up (before exception error is thrown)? If I can't hook I have to implement a filestat to check whether or not a plugin template is present. What's better?

A side note: The reason I've raised this ticket is: Look at compose_newwindow plugin. It failes with an 501 Error when clicking 'compose' within task addressbook in case the database search query fails. With the suggested hook I would be able to handle this exception.

@rcubetrac
Copy link
Author

Comment by @alecpl on 6 Jul 2014 10:08 UTC

Write your code to prevent from such cases. Missing template is a critical error that should not happen and if happens there's not much need in handling it.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 6 Jul 2014 10:08 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant