Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript browser detection #4786

Closed
rcubetrac opened this issue Mar 7, 2015 · 3 comments
Closed

Javascript browser detection #4786

rcubetrac opened this issue Mar 7, 2015 · 3 comments
Labels
bug C: Client Scripts
Milestone
1.1.1

Comments

@rcubetrac
Copy link

Reported by rosali on 7 Mar 2015 05:28 UTC as Trac ticket #1490307

Javascript browser detection in common.js fails for Opera (27.0). Use navigator.userAgent && navigator.userAgent.indexOf('Opera') instead of window.opera.

Migrated-From: http://trac.roundcube.net/ticket/1490307
@rcubetrac
Copy link
Author

Comment by @alecpl on 7 Mar 2015 09:26 UTC

I'm not sure we still need detect new Opera as Opera. Anyway, some pages say we should check for "OPR/" string, e.g. http:_www.opera.com/docs/history/. "Opera" string is used by versions based on Presto engine. http:_www.webapps-online.com/online-tools/user-agent-strings/dv/browser51856/opera

@rcubetrac
Copy link
Author

Comment by @alecpl on 8 Mar 2015 12:50 UTC

Fixed in 06d4243.

@rcubetrac
Copy link
Author

Status changed by @alecpl on 8 Mar 2015 12:50 UTC

new => closed

@rcubetrac rcubetrac added this to the 1.1.1 milestone Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Client Scripts
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
1 participant
@rcubetrac