Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript browser detection #4786

Closed
rcubetrac opened this issue Mar 7, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@rcubetrac
Copy link

commented Mar 7, 2015

Reported by rosali on 7 Mar 2015 05:28 UTC as Trac ticket #1490307

Javascript browser detection in common.js fails for Opera (27.0). Use navigator.userAgent && navigator.userAgent.indexOf('Opera') instead of window.opera.

Migrated-From: http://trac.roundcube.net/ticket/1490307

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Mar 7, 2015

Comment by @alecpl on 7 Mar 2015 09:26 UTC

I'm not sure we still need detect new Opera as Opera. Anyway, some pages say we should check for "OPR/" string, e.g. http:_www.opera.com/docs/history/. "Opera" string is used by versions based on Presto engine. http:_www.webapps-online.com/online-tools/user-agent-strings/dv/browser51856/opera

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Mar 8, 2015

Comment by @alecpl on 8 Mar 2015 12:50 UTC

Fixed in 06d4243.

@rcubetrac

This comment has been minimized.

Copy link
Author

commented Mar 8, 2015

Status changed by @alecpl on 8 Mar 2015 12:50 UTC

new => closed

@rcubetrac rcubetrac closed this Mar 8, 2015

@rcubetrac rcubetrac added this to the 1.1.1 milestone Mar 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.