LDAP password policy #5364
LDAP password policy #5364
Conversation
| case "OK": | ||
| return PASSWORD_SUCCESS; | ||
| case "Password is in history of old passwords": | ||
| return PASSWORD_IN_HISTORY; |
There was a problem hiding this comment.
PASSWORD_IN_HISTORY constant does not exist. Did you forget to commit password.php changes?
There was a problem hiding this comment.
Yes, you're right. I've made new commit with it.
| 2 => array("file", "/tmp/ppolicy_ldap.err", "a") // stderr is a file to write to | ||
| ); | ||
|
|
||
| $cwd = 'plugins/password/drivers/'; |
There was a problem hiding this comment.
Shouldn't this be a path to helpers directory? Also does the command need to be configurable at all?
There was a problem hiding this comment.
I changed it to logs directory. This can be useful in case of any errors.
There was a problem hiding this comment.
First of all you should use log_dir option to get the logs dir location. Second, I was talking about 'plugins/password/drivers/'.
There was a problem hiding this comment.
I'm sorry, I missed that path is not correct and log_dir should be get in propper way now.
|
Last thing, all configuration options of this new driver must have prefix "password_ldap_ppolicy_". Please also solve the merge conflict. |
The password driver to appropriate change password when the PPolicy overlay is installed in openLDAP server.
In plugins/password/drivers/ldap.php i've made small change to work properly with Net_LDAP2 in 2.2.0 version.