Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of self build plugins/jqueryui/js/jquery-ui-1.10.4.custom.min.js #5894

Open
hefee opened this issue Aug 9, 2017 · 2 comments
Open

Comments

@hefee
Copy link
Contributor

hefee commented Aug 9, 2017

actually jquery-ui-1.10.4.custom.min.js is not completly minified and is simply a
cat jquery-ui.min.js plugins/jqueryui/js/jquery-ui-accessible-datepicker.js > plugins/jqueryui/js/jquery-ui-1.10.4.custom.min.js

as it seems that there is only one usecase for this file (plugins/jqueryui/jqueryui.php) it would be nice to move jquery-ui.min.js also to jsdeps.json and simply load the plugins/jqueryui/js/jquery-ui-accessible-datepicker.js directly and not merge the files together. Don't know if that is working, that's why a reponse would help if this way is doable, also how to test...

@alecpl
Copy link
Member

alecpl commented Aug 18, 2017

Eventually we should do jqueryui plugin contents via jsdeps.json, but it's not so simple because:

  1. there's the accessible datepicker code (not a big problem, it could indeed be separated, but hey, one file is better than two),
  2. I couldn't find publicly available jquery.tagedit.js file in a version we're using,
  3. there are not-vanilla css files.
  4. handling only part of it via jsdeps.json does not make much sense, imho.

Also, I think some day we should consider replacing jQuery-UI with something better.

@alecpl alecpl added this to the later milestone Aug 18, 2017
@hefee
Copy link
Contributor Author

hefee commented Aug 22, 2017

in Debian we solved this problem be building a version with source code from the package libjs-jquery-ui (Not a gold solution, but works, and we have updates :)

>plugins/jqueryui/js/jquery-ui-1.10.4.custom.min.js create-jquery-ui-custom.sh 

and create-jquery-ui-custom.sh

#!/bin/sh
#
# The program/js/jquery-ui-1.10.4.custom.js can't be shipped
# because we don't have the source for it.  So construct that
# works the way roundcude wants it from the original sources.
#
# We actually just mung the minified source because it's closest
# to what we want.
#
# We just append jquery-ui-accessible-datepicker.js

cat \
    /usr/share/javascript/jquery-ui/jquery-ui.min.js \
    plugins/jqueryui/js/jquery-ui-accessible-datepicker.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants