Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Updating 1.5.3 to 1.6 removes config options #8645

Closed
jniggemann opened this issue Aug 1, 2022 · 4 comments
Closed

bug: Updating 1.5.3 to 1.6 removes config options #8645

jniggemann opened this issue Aug 1, 2022 · 4 comments

Comments

@jniggemann
Copy link

Updating from 1.5.3 to 1.6, the installer asked to fix my config. I said yes. Big mistake ;-)

The config option $config['ip_check'] was silently deleted, as was $config['enable_spellcheck'].

@sebastian-schmid
Copy link

sebastian-schmid commented Aug 1, 2022

I also tried this feature at upgrade but ended with a config file which was not working. I moved the backup config file back in place and did the needed changes by hand.

Looked to me that a new config file was generated which was missing all of my custom config options.

@sebastian-schmid
Copy link

This Issue looks like a duplicate of #8643 isn't it?

@alecpl
Copy link
Member

alecpl commented Aug 1, 2022

If the option is set to a default value it is being removed from the config. So, that's that. The other part might be that it's a duplicate of #8643.

@jniggemann
Copy link
Author

If the option is set to a default value it is being removed from the config. So, that's that.

Looking for documentation, I only found the wiki) and it describes neither those options nor their default values. Where do I find that information?

Semi-unrelated: Since docs.roundcube.net is last updated in 2015, wouldn't it be better to shut it down altogether?

I moved the backup config file back in place and did the needed changes by hand.

That's what I did, too. But the expectation set by displaying "Would you like me to correct the config?" is more like: Only change what needs changing, otherwise leave it untouched. Personally, while a very good faith effort, I find it a bit unfortunate to remove options from my config, even if they are default options.

Anyway: Duplicate of #8643, closing this.

@jniggemann jniggemann closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants