Correctly handle transport-padding after boundaries. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jebrosen
commented
Jan 26, 2021
|
@jebrosen , @SergioBenitez , any plan for new release? |
|
@rousan Yes, very soon. I also have a few updates to multer itself that break compatibility that I'd like to get in before the release. I'll update you within a week's time. |
|
@jebrosen Could you rebase on |
jebrosen
force-pushed
the
transport-padding
branch
from
e947435
to
d7380c8
Compare
jebrosen
commented
Feb 25, 2021
jebrosen
commented
Feb 25, 2021
|
|
||
| if state.stage == StreamingStage::DeterminingBoundaryType { | ||
| let ext_len = constants::BOUNDARY_EXT.len(); | ||
| let next_bytes = match stream_buffer.peek_exact(ext_len) { |
There was a problem hiding this comment.
I think this check is necessary (including the new peek_exact function) to verify that it is --boundary-- or --boundary[whitespace]CRLF and not --boundaryZZ..., but I would love to be proven wrong.
SergioBenitez
requested changes
Mar 19, 2021
'transport-padding' is defined as any amount of linear whitespace (space or horizontal tab) between a boundary and its corresponding newline. See also https://tools.ietf.org/html/rfc2046#section-5.1.1 Fixes rwf2#25.
SergioBenitez
force-pushed
the
transport-padding
branch
from
dad7c94
to
a40ac8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25.
I'm also installing
cargo-fuzzso that I can try it out with these changes and (if wanted) add some transport-padding to the seeds.