Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native npm commands #4

Closed
wants to merge 2 commits into from
Closed

Use native npm commands #4

wants to merge 2 commits into from

Conversation

FDiskas
Copy link

@FDiskas FDiskas commented Mar 7, 2019

fixes: #1 #2 #3

@rousan
Copy link
Owner

rousan commented Mar 7, 2019

Hey @FDiskas,

Thanks for your PR. But using shell command to get package data is not a stable solution as you might face problem to identify errors e.g. package not found or any internal errors, always prefer to use programmatical API instead of CLI command.
As an instance, do you prefer to use MySQL CLI command to fetch data instead of mysql programming API in your application?

@FDiskas
Copy link
Author

FDiskas commented Mar 7, 2019

reinventing the wheel

@FDiskas
Copy link
Author

FDiskas commented Mar 7, 2019

How you going to solve feature issues like: Private modules, custom registry like bitsrc provides.
And about MYSQL - if you need just single stuff from mysql I wil use mysql cli instead of some big and useless wrapper. It's a good example in your repo lodash and babel. Why it is used if it's not used? :)

@rousan
Copy link
Owner

rousan commented Mar 7, 2019

Hey @FDiskas, you pointed out some unnecessary deps which needs to be removed, thanks for that.
I am not thinking about private modules, custom registry.

@FDiskas
Copy link
Author

FDiskas commented Mar 12, 2019

@rousan Should I resolve conflicts or delete this pull request?

@rousan
Copy link
Owner

rousan commented Mar 13, 2019

Closing it.

@rousan rousan closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking one of my packages returns 401 error
2 participants