Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduxPlugin typing is broken #300

Closed
eatonphil opened this issue May 29, 2018 · 0 comments
Closed

reduxPlugin typing is broken #300

eatonphil opened this issue May 29, 2018 · 0 comments

Comments

@eatonphil
Copy link
Contributor

Hey! I just noticed an issue in the typing of redux-router5 (redux-router5 v6.0.0, react-router5 v6.0.1, router5 v6.2.2).

./node_modules/redux-router5/index.d.ts
(17,28): Type 'TState' does not satisfy the constraint 'Action<any>'.
  Type '{ router: RouterState; }' is not assignable to type 'Action<any>'.
    Property 'type' is missing in type '{ router: RouterState; }'.

The issue appears to be in the reduxPlugin function type. When you are typing the dispatch argument, I believe it expects an object with a type field. But the current typing doesn't include a type field. I deleted this function definition locally and my build completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant