Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFs in source archive #97

Closed
onlyjob opened this issue Mar 18, 2014 · 7 comments
Closed

PDFs in source archive #97

onlyjob opened this issue Mar 18, 2014 · 7 comments

Comments

@onlyjob
Copy link
Contributor

onlyjob commented Mar 18, 2014

In Debian-med we're working on openmolar packaging and we've noticed some (all?) PDFs in src/openmolar/resources that perhaps do not belong with the sources. Also we are concerned that some of those PDFs may be not re-distributable or modifiable, have no documented origins etc.
Could you please review and remove unnecessary PDFs?

Also when PDFs are included to source archive it is good to also include their source(s) so they can be easily modified/re-build when necessary.

Thank you.

@rowinggolfer
Copy link
Owner

Whilst you are quite correct, I am not in favour of openmolar1 being included in debian med.
I see it of no use to anyone other than my own practice.
It is, in short, a dead project.

openmolar2 is potential a valuable addition to your archives, but in need of much further development before being even remotely useful.

regards

Neil Wallace.

@onlyjob
Copy link
Contributor Author

onlyjob commented Mar 18, 2014

I see your point. I packaged openmolar1 since it had more recent activity in repository as well as beta releases. In general openmolar1 looks like quite useful project to me. I've spoken to some dentists in Australia and they expressed their strong dislike to the existing systems that they are forced to use due to absence of any alternatives. I still think that even openmolar1 could be of use for evaluation/education and technology demo even if not production-ready.

By the way our Debian packaging is available from the following repository where you can hopefully get some improvements for your Debian packaging:

Thank you for your work on openmolar.

@rowinggolfer
Copy link
Owner

Thanks for your kind words about the project. Perhaps I will endeavour to strip out some of my own practice stuff and create something I'd be happier to see in debian-med.

With regards to your debian packaging, you may wish to take a peek at my own debian/control file, which can be viewed online https://github.com/rowinggolfer/openmolar1/blob/master/build_scripts/debian_packaging/dh_python2/debian/control

I also assume you are aware that I have packages built (using pbuilder) for oldstable, stable, testing and sid along with recent *buntus in my own repo which can be found at http://static.openmolar.com/debian .

Your package is missing essential dependencies python-mysqldb, xdg-utils, python-qscintilla2.

I like your suggestion of mysql or mariadb though, and manpage patches etc.
I can see you are an expert at debian packaging.

regards

Neil Wallace.

@rowinggolfer
Copy link
Owner

Have pondered over this, and will fix.
I will modify the application to access documents placed in ~/.openmolar/documents/ by the user.

@onlyjob
Copy link
Contributor Author

onlyjob commented Mar 20, 2014

Perhaps I will endeavour to strip out some of my own practice stuff and create something I'd be happier to see in debian-med.

That's great. Thank you very much.

I wasn't aware of your package repository.

Your package is missing essential dependencies python-mysqldb, xdg-utils, python-qscintilla2.

Actually python-mysqldb is there on the second Depends line. I added missing xdg-utils, python-qscintilla2 to Depends. Thank you for telling me about it.

I appreciate your kind words about my packaging skills. As Debian Developer I did a fair bit of packaging but packaging of openmolar is quite straightforward. There are only two things I had to do for Debian policy compliance:

  • Install Pythion modules to private location to avoid exposing them system-wide. This is common practice for applications while libraries are usually exposed in global name space.
  • Add man page. Ideally man page should be maintained upstream so I hope to drop code for manual man page generation with help2man from debian/rules if you merge my pull request added man page #98. :)

@rowinggolfer
Copy link
Owner

as commit shows, this is now fixed. in 0.5.0-beta18
new, configurable document design outlined here http://openmolar.com/om1/help/documents

@onlyjob
Copy link
Contributor Author

onlyjob commented Mar 27, 2014

Thanks, Neil. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants